Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload multi-platform image by uploading separately #4072

Merged
merged 1 commit into from
Dec 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ jobs:
docker:
needs: pypi
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
build: [{ platform: linux/amd64, cache: buildcache-amd64 }, { platform: linux/arm64, cache: buildcache-arm64 }]
steps:
- uses: actions/checkout@v4
- name: Prepare
Expand Down Expand Up @@ -86,18 +82,33 @@ jobs:
with:
context: .
file: ./release.dockerfile
platforms: ${{ matrix.build.platform }}
platforms: linux/amd64, linux/arm64
push: true
tags: ${{ steps.prep.outputs.tags }}
build-args: VERSION=${{ steps.prep.outputs.version }}
cache-from: type=registry,ref=${{ steps.prep.outputs.docker_image }}:${{ matrix.build.cache }}
cache-to: type=registry,ref=${{ steps.prep.outputs.docker_image }}:${{ matrix.build.cache }},mode=max

readme:
runs-on: ubuntu-latest
needs: docker
steps:
- uses: actions/checkout@v4
cache-from: |
type=registry,ref=${{ steps.prep.outputs.docker_image }}:buildcache-amd64
type=registry,ref=${{ steps.prep.outputs.docker_image }}:buildcache-arm64
- name: Cache linux/amd64 to registry
uses: docker/build-push-action@v6
with:
context: .
file: ./release.dockerfile
platforms: linux/amd64
build-args: VERSION=${{ steps.prep.outputs.version }}
push: false
cache-from: type=registry,ref=${{ steps.prep.outputs.docker_image }}:buildcache-amd64
cache-to: type=registry,ref=${{ steps.prep.outputs.docker_image }}:buildcache-amd64,mode=max
- name: Cache linux/arm64 to registry
uses: docker/build-push-action@v6
with:
context: .
file: ./release.dockerfile
platforms: linux/arm64
build-args: VERSION=${{ steps.prep.outputs.version }}
push: false
cache-from: type=registry,ref=${{ steps.prep.outputs.docker_image }}:buildcache-arm64
cache-to: type=registry,ref=${{ steps.prep.outputs.docker_image }}:buildcache-arm64,mode=max
# Uploading the README.md is not a core feature of docker/build-push-action yet
- name: Update README
uses: christian-korneck/update-container-description-action@v1
Expand Down
Loading