Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend REST API to accept settings #7

Open
zavolokas opened this issue Nov 7, 2019 · 3 comments
Open

Extend REST API to accept settings #7

zavolokas opened this issue Nov 7, 2019 · 3 comments

Comments

@zavolokas
Copy link
Owner

Currently library supports some set of settings for image processing but it is not exposed via REST API. It could be beneficial to execute the processing using different settings and allow user to select a result he prefers.

@ferib
Copy link
Contributor

ferib commented Oct 2, 2020

I will look into this, see if I can add an API that submits configuration in JSON format and apply then on every request made by that client (based on IP?).

@zavolokas
Copy link
Owner Author

I will look into this, see if I can add an API that submits configuration in JSON format and apply then on every request made by that client (based on IP?).

2 @ferib:
It's better to keep it stateless and don't store settings per client(especially per IP since one IP can be used per many different users)

The idea is to have a possibility to override existing default settings when making a request to inpaint an image.

@ferib
Copy link
Contributor

ferib commented Oct 4, 2020

@zavolokas Oh yeah, I can just set the settings clientside (local storage) and then send those settings over, together with the image when doing the inpainting request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants