Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping last odd numbered checkpoint #3

Open
ccjernigan opened this issue May 5, 2022 · 0 comments
Open

Consider dropping last odd numbered checkpoint #3

ccjernigan opened this issue May 5, 2022 · 0 comments

Comments

@ccjernigan
Copy link
Contributor

STEPS TO REPRODUCE

  1. Run the command python3 checkmate.py mainnet.lightwalletd.com:9067 --start-height 1650000 --to-json
  2. Look at the output files

RESULTS

Actual

The final checkpoint is not an increment of 10000.

Expected

When generating checkpoints, one provides a starting height and expects checkpoints to be emitted in intervals of 10000. The final checkpoint should probably also follow the 10000 convention.

NOTES

The reason to consider implementing this is to reduce the introduction of odd-numbered checkpoints into the iOS and Android SDKs, as often the person generating the checkpoints will just drag-and-drop the outputs of this script into the SDK and not drop the last checkpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant