Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow or require columns to be named #681

Open
daira opened this issue Oct 18, 2022 · 2 comments
Open

Allow or require columns to be named #681

daira opened this issue Oct 18, 2022 · 2 comments
Labels
A-dev-tooling Area: Developer tooling A-planning Area: Circuit floor planner and layouter logic C-feature-request Category: This is a request for a new feature or functionality.

Comments

@daira
Copy link
Contributor

daira commented Oct 18, 2022

This would already be useful for debugging, but it will become even more important when we support floor planners that can do horizontal optimizations (#195), because at that point it will be infeasibly difficult to keep track of column numbers manually.

It would be logical columns (as used in a particular gadget or region) that are named, rather than global columns.

@daira daira added C-feature-request Category: This is a request for a new feature or functionality. A-dev-tooling Area: Developer tooling A-planning Area: Circuit floor planner and layouter logic labels Oct 18, 2022
@daira
Copy link
Contributor Author

daira commented Oct 18, 2022

I think it would be sufficient for this issue to just pass a closure returning a column name to methods like ConstraintSystem::{advice,fixed}_column. At the moment, circuits tend to manually share columns between gadgets, but once #195 and associated optimizations are implemented, they will not need to do that and so the columns created by {advice,fixed}_column will be "logical columns".

If we also add namespacing to ConstraintSystem as suggested by @str4d in #195, then the column names would be scoped to a namespace. This would help to distinguish columns allocated by the same code in different contexts.

@CPerezz
Copy link
Contributor

CPerezz commented Dec 13, 2022

If we also add namespacing to ConstraintSystem as suggested by @str4d in #195, then the column names would be scoped to a namespace. This would help to distinguish columns allocated by the same code in different contexts.

In #705 they're scoped per Region. I think that PR could probably close this issue too. LMK if it doesen't since I could also implement the missing pieces too so that this issue get's also resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dev-tooling Area: Developer tooling A-planning Area: Circuit floor planner and layouter logic C-feature-request Category: This is a request for a new feature or functionality.
Projects
None yet
Development

No branches or pull requests

2 participants