Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating a poseidon::Transcript primitive. #190

Open
therealyingtong opened this issue Aug 25, 2021 · 2 comments
Open

Consider creating a poseidon::Transcript primitive. #190

therealyingtong opened this issue Aug 25, 2021 · 2 comments

Comments

@therealyingtong
Copy link
Contributor

(analogous to poseidon::Hash)

@therealyingtong
Copy link
Contributor Author

This may introduce a circular dependency between halo2 and the (eventual) poseidon crate:

poseidon::Transcript will have to implement the halo2::transcript::{Transcript, TranscriptRead, TranscriptWrite} traits, i.e. will have a halo2 dependency; however, the halo2 crate has to import poseidon::Transcript to instantiate a transcript.

@daira
Copy link
Contributor

daira commented Aug 26, 2021

halo2 wouldn't necessarily have to import poseidon::Transcript if it were a type parameter provided by the prover and verifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants