-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating a FullViewingKey from a given SpendValidatingKey #432
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, from_sk_and_ak()
alone would be enough for our use case. Added a comment about parameter naming.
d0e37ad
to
6da15c1
Compare
rebased and squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As str4d mentioned, it's better to not link the FROST book which is non-normative, and wait for the ZIP to be finalized and add links to that later.
Allows creating a FullViewingKey from a given SpendValidatingKey and from the other components which can be randomly generated, but there may be some utility in specifying them too like supporting FROST backup schemes that don't centralize spend authority closes zcash#431 see related zcash#430 PR Suggestions
Exposes FVK's components for FROST clients
Fix compile error on non-randomized flavor
Rebased with main |
builds atop #428
Allows creating a FullViewingKey from a given SpendValidatingKey and
from the other components which can be randomly generated, but there
may be some utility in specifying them too like supporting FROST backup
schemes that don't centralize spend authority
closes #431
see related #430