Crash on unsaved new database, all logins gone !!

[mxdmxd]

0. Executable Starkits for Windows 32bit, used on Windows 7 64bit machine.
   https://github.com/downloads/zdia/gorilla/gorilla15363.exe
1. Open first time
2. New database
3. Put in dozens of logins in one subgroup
4. Did not explicitly click "save as"
5. Attempt to close the app window
6. crash when closing, and all the logins are gone!!!

Maybe something wrong with saving the new database for the first time?
If I did "save as" some file in step 4, it does not crash.

In general, how reliable the Executable Starkits of Password Gorrila is? This is scary..

The error log reads:

can't read "::gorilla::fileName": no such variable
can't read "::gorilla::fileName": no such variable
while executing
"gorilla::SaveBackup $::gorilla::fileName "
(procedure "LockDatabase" line 41)
invoked from within
"LockDatabase"
(procedure "::gorilla::IdleTimeout" line 2)
invoked from within
"::gorilla::IdleTimeout"
("after" script)

[zdia]

I did follow your steps:

1. Open first time
2. New database
3. Put in dozens of logins in one subgroup
4. Did not explicitly click "save as"
5. Attempt to close the app window
6. crash when closing, and all the logins are gone!!!

But it did not crash. A warning dialog appeared to remind the user that there are unsaved changes.

Your error message indicates rather that the "LockDatabase" procedure is causing the issue and indeed I can confirm the bug which caused your data loss.

If the keep-backup-file flag is set in the preferences and if the database is locked then this error will be produced because in this early stage there is no filename for the database but only a copy in the memory.

I am sorry for this bug but a patch will immediately close this early stage hole. The next version 1.5.3.7 will have fixed this bug.

[mxdmxd]

Makes sense! I did have backup enabled. I suppose the bug fix will prompt for a filename when the backup happens and no filename is yet available. Thanks for the timely response. I'm all in as user of Gorilla!

[zdia]

"I suppose the bug fix will prompt for a filename when the backup happens and no filename is yet available."

Yes, it does so. Commit 203b4a3 will show you details.

" I'm all in as user of Gorilla!"

You are welcome :-)