Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Offline case #23

Open
0xdeathbed opened this issue Sep 17, 2024 · 2 comments
Open

Handle Offline case #23

0xdeathbed opened this issue Sep 17, 2024 · 2 comments

Comments

@0xdeathbed
Copy link

In case of no internet connectivity
this fails:

 let release = zed::latest_github_release(
            "fwcd/kotlin-language-server",
            zed::GithubReleaseOptions {
                require_assets: true,
                pre_release: false,
            },
        )?;

which end up giving Some("") . And resulting in lsp not starting even if present

@cholwell
Copy link
Contributor

feel free to open a pr

when I have some time I can look if / how other extensions are handling this

@0xdeathbed
Copy link
Author

Some are like this and some use local binary from PATH using worktee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants