Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iceberg Theme #1254

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Add Iceberg Theme #1254

merged 7 commits into from
Aug 26, 2024

Conversation

EFDos
Copy link
Contributor

@EFDos EFDos commented Aug 16, 2024

Adds iceberg theme to zed extensions.

Copy link

cla-bot bot commented Aug 16, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @EFDos on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@EFDos
Copy link
Contributor Author

EFDos commented Aug 16, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2024
Copy link

cla-bot bot commented Aug 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

It looks like your extension.toml is missing the repository field.

@EFDos EFDos requested a review from maxdeviant August 26, 2024 00:50
@EFDos
Copy link
Contributor Author

EFDos commented Aug 26, 2024

Thanks, I've updated the extension.toml file.

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit d4d5bae into zed-industries:main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants