Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keybind conflict for ctrl-enter used for both assistant::InlineAssist and editor::NewlineAbove on linux #24501

Open
lsunsi opened this issue Feb 8, 2025 · 3 comments

Comments

@lsunsi
Copy link

lsunsi commented Feb 8, 2025

Summary

With the default keymap I can never use new line above or below keybindings.

I think just reading the keymap there may be some overlap for Editor && mode == full context, but I can't quite be sure because I don't know exactly how it all works.

Is this a bug or a feature? haha Either way maybe some clarification on expected behavior is needed and if there's indeed overlap, it might make sense to figure out a way to expose both shortcuts.

Steps to trigger the problem:

  1. Open editor
  2. Place cursor anywhere
  3. Press ctrl-enter

Actual Behavior:
assistant::InlineAssist

Expected Behavior:
editor::NewlineAbove

Zed Version and System Specs

Zed: v0.172.9 (Zed)
OS: Linux Wayland fedora 41
Memory: 30.4 GiB
Architecture: x86_64
GPU: AMD Radeon RX 6600 (RADV NAVI23) || radv || Mesa 24.3.4

@probably-neb
Copy link
Contributor

probably-neb commented Feb 11, 2025

Thanks for reporting this, this is a known issue on Linux. We're still working on the default bindings for AI related stuff and hope to have this resolved soon.

Regarding the "possible overlap" you are entirely correct - you can clearly see the overlap in zed: open default keymap when you search for ctrl-enter.

For now I recommend rebinding one of them to avoid the conflict.

Sorry we didn't catch this before it reached you!

@probably-neb probably-neb changed the title Can't use NewLineAbove and always get InlineAssist (possible overlap) Conflict between ctrl-enter being default for both assistant::InlineAssist and editor::NewlineAbove on linux Feb 11, 2025
@probably-neb probably-neb changed the title Conflict between ctrl-enter being default for both assistant::InlineAssist and editor::NewlineAbove on linux Default keybind conflict for ctrl-enter used for both assistant::InlineAssist and editor::NewlineAbove on linux Feb 11, 2025
@lsunsi
Copy link
Author

lsunsi commented Feb 11, 2025

@probably-neb Thanks for answering, yeah I already did that but thought it'd be great if it worked out of the box.

@probably-neb
Copy link
Contributor

Totally agree. Thanks for the understanding. We're working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants