Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane magnification can cause mouse to drag tabs unexpectedly #24600

Open
Nairou opened this issue Feb 11, 2025 · 1 comment
Open

Pane magnification can cause mouse to drag tabs unexpectedly #24600

Nairou opened this issue Feb 11, 2025 · 1 comment
Labels
setting Feedback for preferences, configuration, etc tabs Feedback for tabs behavior, navigation, style, etc

Comments

@Nairou
Copy link

Nairou commented Feb 11, 2025

Summary

When using split pane, as well as active_pane_modifiers.magnification, clicking a tab on the second pane can cause the mouse to go into drag-tab mode if the click ends up outside of the tab due to the pane size change.

2025-02-10_21-39-41.mp4

Steps to trigger the problem:

  1. Set active_pane_modifiers.magnification to a value greater than 1.0.
  2. Split the pane vertically and open multiple tabs on each pane.
  3. With the left pane active, click a tab on the right pane.
  4. Right pane will expand due to magnification, which will shift the position of the tabs, potentially leaving the mouse mid-click but no longer over the clicked tab.

Actual Behavior:

Zed thinks you want to drag the tab order, even though it was the tab that moved instead of the mouse cursor.

Expected Behavior:

Cancel any tab dragging checks when switching panes (at least when magnification is enabled).

Zed Version and System Specs

Zed: v0.172.9 (Zed)
OS: Linux Wayland nixos 25.05
Memory: 62.7 GiB
Architecture: x86_64
GPU: AMD Radeon RX 6800 XT (RADV NAVI21) || radv || Mesa 24.3.4

@probably-neb
Copy link
Contributor

Hey, sorry this is happening. Definitely not the desired behavior. Thanks for reporting!

@JosephTLyons JosephTLyons added tabs Feedback for tabs behavior, navigation, style, etc setting Feedback for preferences, configuration, etc labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setting Feedback for preferences, configuration, etc tabs Feedback for tabs behavior, navigation, style, etc
Projects
None yet
Development

No branches or pull requests

3 participants