Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Finder forgets open buffers when filtering #24670

Open
djrenren opened this issue Feb 11, 2025 · 2 comments
Open

File Finder forgets open buffers when filtering #24670

djrenren opened this issue Feb 11, 2025 · 2 comments
Labels
file finder Feedback for file management, navigation, etc reproducible Verified steps to reproduce included

Comments

@djrenren
Copy link

djrenren commented Feb 11, 2025

Summary

If I have an open file that is outside the current workspace, I cannot open it by typing its name in file finder

Steps to trigger the problem:

  1. Create a workspace folder demo
  2. Open demo in zed.
  3. Open a terminal (ctrl-`) and create a new file one directory up touch ../findme.txt
  4. Open that file in the current zed window zed ../findme.txt
  5. Open the file finder cmd-p (Note that findme.txt is listed)
  6. Type a prefix of its name: fi
  7. Note that file finder reports "no matches"

Actual Behavior:
File finder is unable to locate a file it previously knew about

Expected Behavior:
It should list the file after typing a prefix of it.

Zed Version and System Specs

Zed: v0.172.10 (Zed)
OS: macOS 15.0.1
Memory: 36 GiB
Architecture: aarch64

@djrenren
Copy link
Author

I've looked at the File Finder source code and can see what's happening. It has the notion of workspace files and "history".

Initial contents include "history" but upon filtering the history is lost. History is also distinct from the list of open buffers. This means if your extra-workspace file (findme.txt) ages out of this list, it's incredibly hard to find.

@JosephTLyons JosephTLyons added file finder Feedback for file management, navigation, etc reproducible Verified steps to reproduce included labels Feb 11, 2025
@JosephTLyons
Copy link
Collaborator

Nice catch @djrenren - strange that its in the list initially, but not when searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file finder Feedback for file management, navigation, etc reproducible Verified steps to reproduce included
Projects
None yet
Development

No branches or pull requests

2 participants