Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Replace MCO with BFCO #130

Open
Aqua-Markwin opened this issue Aug 5, 2024 · 5 comments
Open

Suggestion: Replace MCO with BFCO #130

Aqua-Markwin opened this issue Aug 5, 2024 · 5 comments
Labels
enhancement New feature or request fixed in dev This issue has been fixed for the next release

Comments

@Aqua-Markwin
Copy link

Aqua-Markwin commented Aug 5, 2024

Describe the Feature
BFCO is a new framework that is backwards compatible with MCO animations (after converting them via a tool), that allows the use of Jumping and Swim attacks (in third person only as of writing this). Jump attacks are tied to the combo key in BFCO's MCM, and while I'm not sure where it would be best to map that key to in game, I seem to be doing alright just setting it to E and sheathing my weapon to not power attack while interacting with things. I held off suggesting this before now because it didn't support DMCO until a few days before I made this suggestion, but now it gladly does.

Link to Mod(s)
BFCO: https://www.nexusmods.com/skyrimspecialedition/mods/117052
MCO to BFCO Converter: https://www.nexusmods.com/skyrimspecialedition/mods/119926

Additional Notes
BFCO's built in power attack key is also a great replacement to having to use One Click Power Attack NG for people who don't want to use For Honor Power Attack, as it's mentioned that OCPA has issues in this list's wiki.

@Aqua-Markwin Aqua-Markwin added enhancement New feature or request Needs triage labels Aug 5, 2024
@zediious zediious added needs diag This issue needs further diagnostics to find the cause and removed Needs triage labels Aug 7, 2024
@zediious
Copy link
Owner

zediious commented Aug 7, 2024

I am currently in the process of integrating this over MCO. I've converted all currently used animations, and they're working great.

Having removed For Honor Power Attack before doing so, main kink I'm trying to iron out is when using right click for power attack as a hotkey, block is sometimes still being registered. Impossible to "unbind" block as it's attached to many other vanilla functions. This is inconsistent, and I’ve found times where I can easily just power attack and chain many power attacks with no block action, but I sometimes am unable to do so.

At first I was dealing with the Stress mechanic from Stress and Fear, but I disabled that and it does occur occasionally. Possible it’s related.

Am continuing to work on this as the chain-ability of attacks is so immensely improved with BFCO. It also cannot be understated how great jumping and swimming attacks are, they work amazingly.

@Aqua-Markwin
Copy link
Author

Aqua-Markwin commented Aug 7, 2024

Is there any problem with just continuing to use For Honor Power Attack for Right Click? I've used it with BFCO before the MCM update and it seemed fine.

Sorry for closing and reopening, that was a misclick.

Edit: I just had the chance to test For Honor Power Attack (Vanilla, not MCO version) on the Current version of BFCO, and it seems to be working the same as BFCO's power attack key set to a keyboard button. Though I could be not seeing some edge case.

Edit, Again: Never mind, some further testing led me to blocking while dual wielding in a state where I would not normally be able to block without dual wield parrying while using For Honor Power Attack (Vanilla). Very strange.

@zediious
Copy link
Owner

zediious commented Aug 8, 2024

What I have done is re-enabled For Honor Power Attack (realizing now I am still using the MCO version). I made sure that BFCO is overwriting the single record that conflicts with FOPA.

In BFCO MCM, I've used "Automatic" for holding down left click to continuously light attack, and I set the power attack key the a random key (SCRLK in this case, never touch that). For Honor Power Attack still causes power attack on right click.

Also set the "combo power attack" key to middle mouse click, moved FOV switch to N. This seems to just do a single power attack animation, it's just looking for a specific filename. Could do some neat stuff with this per weapon.

This is doing what I want, I have not been able to produce a blocking state with power attack. There are times where you can basically "re-start" your attack if you press the power attack key too quickly before the attack finishes, but if you allow it to get about 50%~ through it will chain another.

Most of the movesets are not really designed for this, so sometimes there is some noticeable weirdness as the player quickly gets into position to start the new animation.

Overall it's working quite nicely, continuing to playtest. No less jank than MCO can be at times :p

If you're able to try what I did above, let me know how it goes!

@zediious zediious added the help wanted Extra attention is needed label Aug 8, 2024
@Aqua-Markwin
Copy link
Author

Aqua-Markwin commented Aug 8, 2024

I can confirm that using the MCO version of FHPA and creating a patch in xEdit to allow GBlocking(something) to overwrite Blocking(something) from FHPA does fix the weird blocking issue on my end. I've personally gotten weirdly used to setting dodge to be part of sprint like Dark Souls, and setting the combo key to space now, but I think moving FOV is probably better for the average player. I also have lock-on tied to the FOV button instead of M5 because it's annoying to click on my mouse.

I'm unsure if me switching to the MCO version of FHPA was necessary or not.

@zediious zediious added the fixed in dev This issue has been fixed for the next release label Aug 8, 2024
@zediious
Copy link
Owner

zediious commented Aug 8, 2024

Overall it seems to be working great!

Confirmed Elden Counter also still works after converting the animations.

This has been completed for all intents and purposes, and improvements can come with new animations from what we were already using. Will have this in the next version, and continue to tinker with it :)

@zediious zediious removed help wanted Extra attention is needed needs diag This issue needs further diagnostics to find the cause labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in dev This issue has been fixed for the next release
Projects
None yet
Development

No branches or pull requests

2 participants