Skip to content

Exercise Session Reporting two outcomes for the same exercise #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tfnribeiro opened this issue Oct 3, 2024 · 3 comments
Open

Exercise Session Reporting two outcomes for the same exercise #574

tfnribeiro opened this issue Oct 3, 2024 · 3 comments

Comments

@tfnribeiro
Copy link
Contributor

2024-10-03 10:51:14      9      C undskyld        Click_L1W_in_L2T   
2024-10-03 10:51:37      0 other_feedback undskyld        Click_L1W_in_L2T   
2024-10-03 10:51:42      4      C ret             Click_L1W_in_L2T   

Nr. 2 is still referring to the same exercise, however in the email summary it looks like 2 different exercises.

@mircealungu
Copy link
Member

also, other_feedback seems to be saved, although I have selected the "do not show again" button and then chose the "too easy" reason.

@tfnribeiro
Copy link
Contributor Author

That is to be expected. All feedbacks now have the outcome of "other_feedback" which then can be checked to see the feedback column to see what was the feedback.

Looking at the code, the user can send this both before the exercise (which then is the outcome) and after completing the exercise. Both are set to have time 0, so I guess if we see the same word twice with the same exercise type, but one has other_feedback and time 0 then it's because the user completed the exercise and then gave feedback.

When we send this situation, I think we could technically change slightly the reporting of the exercise outcome, but I think we do this because in the backend we now unscheduled the words that are given feedback based on the "other_feedback" tag.

@tfnribeiro
Copy link
Contributor Author

Linking the discussion on the API as this might be relevant: zeeguu/api#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants