Skip to content

Do we need the Save button? #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mircealungu opened this issue Apr 8, 2025 · 1 comment
Open

Do we need the Save button? #753

mircealungu opened this issue Apr 8, 2025 · 1 comment
Assignees

Comments

@mircealungu
Copy link
Member

@igawaclawska - could we maybe make the languages into buttons and remove the Save button?

Image
@igawaclawska
Copy link
Contributor

igawaclawska commented Apr 8, 2025

I think we can still keep these options as radio buttons, just save changes in real-time with useEffect, instead of onSubmit. I will explore the pros and cons of this option further tomorrow / after I'm back from vacation.

Edit: I would keep the "Save" button for now, among other reasons, for better error prevention (avoiding misclicks), but not only. I will go into more details when I return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants