Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to ignore dirty local git clone #158

Open
mmguero opened this issue Mar 9, 2023 · 2 comments · Fixed by #161
Open

add flag to ignore dirty local git clone #158

mmguero opened this issue Mar 9, 2023 · 2 comments · Fixed by #161

Comments

@mmguero
Copy link

mmguero commented Mar 9, 2023

When doing zkg install, a check is made to ensure the local repository isn't dirty. If it is, the install fails.

For development purposes, it would be convenient to have a flag named something like --ignore-dirty-git that would allow the install operation to proceed anyway.

e.g.

$ touch asdfasdf

$ zkg install .
error: local git clone at . is dirty

$ zkg install --ignore-dirty-git .
The following packages will be INSTALLED:
...

related to #145

@awelzel
Copy link
Contributor

awelzel commented Feb 20, 2024

Reopening as the change was reverted with #179

@awelzel awelzel reopened this Feb 20, 2024
@mmguero
Copy link
Author

mmguero commented Feb 20, 2024

Thanks, I had noticed this behavior ("The existing implementation isn't function and behaves confusingly (silently discards the actual changes during install/test)") and hadn't gotten around to trying to figure out if I was doing something wrong or if it was a problem with zkg itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants