Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression parser is not able to handle associative arrays inside expression #1

Open
tolecar opened this issue Dec 8, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@tolecar
Copy link
Member

tolecar commented Dec 8, 2020

While evaluating strings, EvalContext:_extractExpressions() has to parse out all expressions which are defined with ${}. As the PHP associative array syntax uses curly brackets too, current parsing mechanism is not able to handle it right,

Example:

indexed array is OK ${count(['a', 'b'])}
associative array will fail ${count({'a'=>'option', 'b'=>'other option'})}

Requirements:

  • add unit test which will test associative array parsing (and will fail currently)
  • improve parsing to support use of associative arrays

Side note:

It seems like this functionality might be migrated to the https://github.com/zef-dev/zef-expression-language library

@tolecar tolecar added the bug Something isn't working label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant