Attempt d_a_obj_tower_hand_D101 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
commented
Nov 9, 2024
Comment on lines
+67
to
+70
| void transS(const mVec3_c &v) { | ||
| PSMTXTrans(*this, v.x, v.y, v.z); | ||
| } | ||
| void trans(f32 x, f32 y, f32 z) { | ||
| void transS(f32 x, f32 y, f32 z) { |
There was a problem hiding this comment.
Going with the existing pattern of an S suffix for functions that Set the matrix and M for functions that Modify/Mutate the matrix
| } | ||
| } | ||
|
|
||
| if (item == nullptr || !item->isStateWait()) { |
There was a problem hiding this comment.
All code surrounding isStateWait in this file is weird!
Comment on lines
+517
to
+525
| inline u32 getFlags() { | ||
| static volatile u32 FLAGS_1 = 0x00000001; | ||
| static u32 FLAGS_2 = 0x00100001; | ||
| // The remarkable bit here is that this does not use an `andc` instruction, | ||
| // but rather `nor`s FLAGS_1, contrary to the other usages so far | ||
| u32 f1 = ~FLAGS_1; | ||
| u32 f2 = FLAGS_2; | ||
| return f2 & f1; | ||
| } |
|
This is as close as it gets. A lot of unused rodata (floats), and the getItem inline is weird, but it should be pretty much equivalent now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.