Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact Mode does not hide the address bar #2974

Open
4 tasks done
fillwithjoy1 opened this issue Nov 13, 2024 · 3 comments
Open
4 tasks done

Compact Mode does not hide the address bar #2974

fillwithjoy1 opened this issue Nov 13, 2024 · 3 comments
Labels

Comments

@fillwithjoy1
Copy link

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

My zen browser now does this. I checked and compact mode was enabled, which means that the top bar should disappear but it doesn't. And it makes it extremely inconvenient to use the browser as menu items have been cut off. How can I fix this?

image

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

Version 1.0.1-a.19 (64-bit)

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Copy link

dosubot bot commented Nov 13, 2024

I found a related issue that might be helpful:

  • Hiding sidebar in compact mode bugs out (doesn't hide) #2945
    The suggested solution is to disable the expand-on-hover feature, use the button on the top left or the keyboard shortcut Alt + b to manage the sidebar, and adjust CSS settings in the zen-compact-mode.css file. Ensure JavaScript functions like _disableTabsOnHoverIfConflict and toggleSidebar are correctly managing the sidebar's state.

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the Bug label Nov 13, 2024
@fillwithjoy1
Copy link
Author

I found a related issue that might be helpful:

* [Hiding sidebar in compact mode bugs out (doesn't hide) #2945](https://github.com/zen-browser/desktop/issues/2945)
  The suggested solution is to disable the expand-on-hover feature, use the button on the top left or the keyboard shortcut `Alt + b` to manage the sidebar, and adjust CSS settings in the `zen-compact-mode.css` file. Ensure JavaScript functions like `_disableTabsOnHoverIfConflict` and `toggleSidebar` are correctly managing the sidebar's state.

To continue talking to Dosu, mention @dosu.

Does not work @dosu

Copy link

dosubot bot commented Nov 13, 2024

If the suggested solution didn't work, you might want to check the following:

  1. Preferences Settings: Ensure that the preferences zen.view.compact and zen.view.compact.hide-tabbar are set correctly. The compact mode should be enabled (zen.view.compact set to true), and if you want the tab bar hidden, ensure zen.view.compact.hide-tabbar is also true.

  2. JavaScript Functions: Verify that the _disableTabsOnHoverIfConflict function is being executed properly. This function should disable the expand-on-hover feature if there's a conflict with the compact mode settings [1][2].

  3. CSS Adjustments: Double-check the zen-compact-mode.css file to ensure that the CSS rules are correctly set to hide the address bar in compact mode. Although I couldn't find specific rules in the repository, you might need to manually adjust them if they are not working as expected.

  4. Browser Version: Make sure you are using the latest version of the browser, as updates might have fixed related issues.

If these steps don't resolve the issue, there might be a deeper problem in the codebase that requires further investigation.

To continue talking to Dosu, mention @dosu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Triage
Development

No branches or pull requests

1 participant