Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color #4261

Closed
4 tasks done
KoB-Kirito opened this issue Jan 10, 2025 · 67 comments
Closed
4 tasks done

Theme color #4261

KoB-Kirito opened this issue Jan 10, 2025 · 67 comments
Labels

Comments

@KoB-Kirito
Copy link

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

The new update uses the windows theme color suddenly. My zen menu and top bar are pink now and I can't find a way to change that back.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.6b

What platform are you seeing the problem on?

Windows

Relevant log output if applicable

No response

Data from about:support if applicable (click on the "Copy text to clipboard" button)

about:support
Select this line and paste your about:support clipboard
Copy link

dosubot bot commented Jan 10, 2025

I found 1 similar issue that might be helpful:

[1] The suggested solution is: Try going to Windows settings > Personalization > and disabling accent color on title bars. This relates to your issue as it addresses the unexpected theme color changes in the application.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added the Bug label Jan 10, 2025
@KoB-Kirito
Copy link
Author

@dosu No, I want to use the accent color on other windows, just not on zen. It's used abnoxiously there.

Copy link

dosubot bot commented Jan 10, 2025

To disable the use of the Windows accent color specifically for the zen menu and top bar, you can override the CSS variable --zen-colors-primary in the application's stylesheet. This variable is used to apply the theme color to these components. You can redefine it in your custom CSS to set a different color for the zen menu and top bar without affecting other windows.

Here's an example of how you might override this in your CSS:

/* Override the primary color for the zen menu and top bar */
.zen-menu-class, .zen-top-bar-class {
  --zen-colors-primary: #yourPreferredColor;
}

Replace .zen-menu-class and .zen-top-bar-class with the actual classes used in the application for these components, and #yourPreferredColor with the color you want to use [1].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@FlawlessCasual17
Copy link

Please revert, this is a horrible change that no one on Windows wants!

@GoremanX
Copy link

This behavior is new since 1.6b and it's awful. There's no reason to be using a colored theme if Zen is going to override it with the Windows accent color. Please either change it back or make it optional.

@rayn-i
Copy link

rayn-i commented Jan 10, 2025

Yes, please fix it. The Windows accent color setting is not supposed to affect the contents of a window.

@szpatrik5
Copy link

This change breaks transparency (and looks terrible). Please make it optional, I don't want to disable it system-wide just to make one browser look acceptable.

@PillowTrauma
Copy link

PillowTrauma commented Jan 10, 2025

Same, entire sidebar and title bar are using the Windows accent colour, regardless of whether mica flags are enabled or not. I went through about:config and toggled everything with color, accent, windows, restarting Zen between each switch, but there was no change.

Edit: The background of a tab is also the Windows accent colour before any of the content loads.

@j4yn1ck5
Copy link

I appreciate that this is a fix to the previous buggy accent color at the top of the window with mica turned on. But now this forces me to disable my accent color system-wide to get rid of this thick purple outline, or just deal with it because I like the thin purple outline on Windows File Explorer.

I would love for there to be a way to disable usage of the system accent color for Zen alone without affecting the rest of my system if this is the way the accent color is going to be used on Zen.

@SearingEchoes
Copy link

+1 to making it an option as I really really do not like how it uses the Windows accent colors, I would love a toggle have it behave as it did previously, without being affected by the Windows theme at all.

@11-Lambda
Copy link

Beyond the problem of using Windows colors, this issue appears to prevent Firefox themes from applying as well. I would personally like to use one of those.

@JSGRD22
Copy link
Contributor

JSGRD22 commented Jan 11, 2025

By fluent design principles, the neutral palette is used on used on surfaces, text, and layout elements, whereas accent colours should be used sparingly to accent and highlight important areas of an interface. This is what the operating system's accent colour is meant for—to highlight important items worth the user's attention. By applying it to the entire toolbar, the visual hierarchy is diluted to the point where the element which is supposed to stay out of the way becomes the most distracting. This makes no sense from a design standpoint, and reverting this change is most appropriate.

@A2va
Copy link

A2va commented Jan 11, 2025

It also breaks light theme
image

firestormjupiter form the discord has a workaround. Go to the Windows settings, and disable: Show accent colors on tile bars and window borders

@cmwmlw
Copy link

cmwmlw commented Jan 12, 2025

Add me to the growing list of people who don't like this change. There is no system-wide Windows setting that somebody should be forced to modify in order for a browser to work correctly with themes.

@greenspacegames
Copy link

@dosu where can i find the applications stylesheet

@greenspacegames
Copy link

hi all i'd like to share some leads i have on fixing this:
i used this guide to learn about editing files https://docs.zen-browser.app/guides/live-editing

i located browser-colors.css, which contains the line
@media not ((-moz-windows-mica) or ((-moz-windows-accent-color-in-titlebar) and (-moz-bool-pref: "browser.theme.windows.accent-color-in-tabs.enabled"))) --- from here it defines light/dark defaults

so... without this line i guess it would use defaults? deleting it didn't work and i dont fully understand the capabilities of the toolbox. maybe i would have to reference it though a userChrome file to functionally edit it? and my toolbox refuses to detect a userchrome file in the chrome folder and i'm lost so goodnight

@GoremanX
Copy link

The fix is easy, the change needs to be reverted.

I couldn't tolerate this, so I switched to a different web browser altogether.

@FlawlessCasual17
Copy link

The fix is easy, the change needs to be reverted.

I couldn't tolerate this, so I switched to a different web browser altogether.

Another option I found is to downgrade from this version to the previous version.

@GoremanX
Copy link

That requires disabling automatic updates, and downgrading an existing installation can lead to wonky issues

@cmwmlw
Copy link

cmwmlw commented Jan 13, 2025

Another option I found is to downgrade from this version to the previous version.

The files have a .mar extension. From what I can tell that's associated to Microsoft Access database, something that was retired many years ago. Do you know if there's a zip version instead? I'd definitely reinstall the previous version, wait until they fix this bug.

@mauro-balades
Copy link
Member

Duplicate of #3546

@mauro-balades mauro-balades marked this as a duplicate of #3546 Jan 13, 2025
Copy link

dosubot bot commented Jan 13, 2025

You can typically find the application's stylesheet within the installation directory of the application. Look for a folder named something like styles, css, or assets. If the application allows for custom CSS, there might be a specific location or file where you can add your overrides. If you're using a browser like Zen, you might also find options to add custom CSS directly through the browser's settings or developer tools. If you're unsure, checking the documentation or support resources for the application might provide more specific guidance.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@mauro-balades
Copy link
Member

Let me clarify some things:

We've added this because windows renders an accent-colored bar at the top of the window. We draw the whole browser so it can't be looked at, Check out #3693.

The solution I could try out is by displaying this accent color BELOW the workspace gradients, at least

@mauro-balades mauro-balades reopened this Jan 13, 2025
@KoB-Kirito
Copy link
Author

As I said, I already added a fix to today's twilight, see how it feels.

Did @PillowTrauma not just post a picture of that fix? I don't see any difference.

@JSGRD22
Copy link
Contributor

JSGRD22 commented Jan 14, 2025

Did @PillowTrauma not just post a picture of that fix? I don't see any difference.

Nope, that's an older build

@PillowTrauma
Copy link

@KoB-Kirito The twilight with the fix is still building, mauro corrected me a couple posts up and gave a link to see its progress.

@KoB-Kirito
Copy link
Author

I see. Will try tomorrow then. Already midnight here. Thank you for the effort.

@PillowTrauma
Copy link

I had a go at the new twilight version. If the contrast on the workspace theme colour picker is all the way left, then it is the same as before. Only the accent colour is used, and adding more colours has no effect. Moving contrast to the right lets me add colours, but its not possible to have a dark colour. So it seems Zen cannot be dark while having a light Windows accent colour.

No worries though, I can live without the accent colour. Thanks for trying anyway, @mauro-balades

@JSGRD22 JSGRD22 mentioned this issue Jan 14, 2025
4 tasks
@mauro-balades
Copy link
Member

Another solution would be to only apply this effect when only having mica enabled...

@KoB-Kirito
Copy link
Author

grafik
That's the latest twilight I guess? What exactly has changed now? The accent color is still everywhere.

@JSGRD22
Copy link
Contributor

JSGRD22 commented Jan 15, 2025

That's the latest twilight I guess? What exactly has changed now? The accent color is still everywhere.

You should be able to overwrite it by setting a theme colour this time. If you're not satisfied with this workaround, you may reopen the issue.

@mauro-balades mauro-balades pinned this issue Jan 15, 2025
@mauro-balades
Copy link
Member

mauro-balades commented Jan 15, 2025

That's the latest twilight I guess? What exactly has changed now? The accent color is still everywhere.

Today's twilight should only have it when mica is enabled. I really can't think of a better solution right now... Again, if someone has a better fix than "Just revert it", please let me know.

@JSGRD22
Copy link
Contributor

JSGRD22 commented Jan 15, 2025

That's alright, it appears the developers of edge ran into the same problem... but do remember that people neither expect the bug nor expect their entire toolbar to be themed, so everyone should be happy if there is a simple implementation to automatically disable mica when the windows setting is enabled. Is that possible?

@j4yn1ck5
Copy link

j4yn1ck5 commented Jan 16, 2025

Confirmed that if I turn off mica, I get what I used to have.

However, I took the suggestion and applied #00000000 as my theme color. And it created a black-to-purple gradient with my accent color, and a translucent (compact mode hidden) toolbar. Purrrr.

@KoB-Kirito
Copy link
Author

@j4yn1ck5 What is mica and where do you apply a theme color? Can you show how that would look like?

@j4yn1ck5
Copy link

j4yn1ck5 commented Jan 17, 2025

@KoB-Kirito If you open a tab and navigate to about:config (Accept The Risk And Continue) you can search for a flag called "widgets.windows.mica". If you then toggle this value to false, and restart your browser, the accent color should disappear if you're running version 1.7b. And you'll be left with your ordinary light or dark browser background.

Mica is supposed to be an effect in Windows that subtly tints the color of windows and your taskbar in response to your wallpaper.

Now what I did was, I left the widgets.windows.mica flag toggled to true. I then right-clicked the toolbar up where the address bar and extensions live, and found an option called Change Theme Colors. In that menu, you can add hex color codes to your browser's background, adjust contrast and texture values (which I'm not sure what they do) and a 360 degree angle setting.

I started with a six-digit (#)000000 color code which covered my accent color entirely in black. And then, I reasoned from previous experience that I could add another two digits to the color code for an alpha transparency value, and added eight digit (#)00000000. I noticed that part of my background was black and part of it was purple in a gradient from one corner to the other. And another interesting effect was that my toolbar was translucent.

What I didn't realize when I made my previous comment here was that the state I was in was that both of the color codes I entered were being used. So this thing is actually additive, using all the color codes you've saved. So after that, I played with the 360 degree slider and found that when the black part of the background was centered over the toolbar, the toolbar was opaque. But when the purple was over the toolbar, it was translucent. So that's why I could still see purple, because the transparent code was on the purple part. I then entered another 6 digit hex code for a dark blue, and the 6 digit black again after that. So now, I have a sort of 4-stage 3-tone gradient going from the bottom left of my screen to the top right, black>blue>black>purple. (The full effect of the gradient background can be seen just as a new webpage is being loaded.) And my (compact mode, hidden but displayed on mouse hover) toolbar is translucent over the website material when it's in focus, because the 8-digit transparent color code is in effect on that part of the window.

I've grown to like this state of personalization more than how I had it before 1.6b.

Image

@KoB-Kirito
Copy link
Author

I see!
Not sure how you got it transparent (00 alpha does nothing), might be a windows 11 thing, but you can limit the area of the color kinda via stacking the other color a bunch of times.
Image

Image

Works for me. I want to see which window is active, just not everywhere.

@j4yn1ck5
Copy link

@KoB-Kirito It doesn't look to me like you're using compact mode/hide both toolbars like I am. That could be it. What happens is, where the transparency layer is, I see the purple from my Windows accent color. But because the purple is up at the top of the window, the transparency applies to the hidden toolbar. When I hover the mouse to bring out the toolbar, it displays over the rendered webpage, making its translucency apparent.

@cmwmlw
Copy link

cmwmlw commented Jan 17, 2025

For me widgets.windows.mica seems to work the same whether it's true or false, but I guess that's irrelevant. What does matter is I don't have that bizarre blue border color anymore with 1.7b. Getting rid of that was the most important thing for me.

@FlawlessCasual17
Copy link

FlawlessCasual17 commented Jan 19, 2025

Also, if you don't want the gradient theme to show in the Zen Browser, you turn it off by switching the zen.theme.gradient option to false in about:config.

Image

@j4yn1ck5
Copy link

@FlawlessCasual17 I thought when turning that gradient flag off that it might give me solid stripes or something. But, the result looks the same as if I had turned off the mica flag?

@nhumrich
Copy link

Also, if you don't want the gradient theme to show in the Zen Browser, you turn it off by switching the zen.theme.gradient option to false in about:config.

This was the workaround for me that fixed the issue. Thanks

@FlawlessCasual17
Copy link

@FlawlessCasual17 I thought when turning that gradient flag off that it might give me solid stripes or something. But, the result looks the same as if I had turned off the mica flag?

Have you tried switching the widgets.windows.mica option to false, and the zen.theme.gradient to false?

If that doesn't work, try opening another issue.

@j4yn1ck5
Copy link

@FlawlessCasual17 Oh, that's not what I mean. What I have observed on my end is now that if either/or of those two flags is switched to false, the Windows Accent color disappears to reveal the ordinary background of my Dark Theme, which I would previously have found satisfactory to resolve this (now closed) bug. But I had no sense to look at the gradient flag until recently when it started to be discussed in this issue.

I don't need any further troubleshooting. I just didn't know what to expect from that flag and was surprised by my result.

@FlawlessCasual17
Copy link

Sorry for misunderstanding you, I thought you were still having trouble with the accent colour issue.

@lonelyteapot
Copy link

lonelyteapot commented Jan 30, 2025

This needs to be reopened. As already stated, the sidebar (and the whole browser frame) is indeed not a "title bar" design wise, and no reasonable user expects their sidebar to change color when toggling the Windows setting for title bars.

No themes were applying for me. Finding a solution has been more frustrating than it had to be. At first I thought there was a conflict somewhere, so I did a clean reinstall that did not help. Then had to read this whole thread to find j4yn1ck5's workaround. Please at list pin it somewhere

@jinhei
Copy link

jinhei commented Jan 30, 2025

A setting to disable this seems like a fair trade-off as well, at least.

@JSGRD22
Copy link
Contributor

JSGRD22 commented Jan 31, 2025

@jinhei In the latest versions, you can disable it by disabling widget.windows.mica in about:config. This is necessary as the title bar colour will always be shown in the bar at the top whenever accent colours on title bars are enabled in windows, and this cannot be fixed. I still think mica should be disabled by default whenever that setting is activated, instead of colouring the entire browser frame.

@leic4u
Copy link

leic4u commented Feb 7, 2025

I then right-clicked the toolbar up where the address bar and extensions live, and found an option called Change Theme Colors.

@j4yn1ck5 Thanks bro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests