From 7ad2d88ab85e5d24ce1d1509d54d369459ad9a33 Mon Sep 17 00:00:00 2001 From: Rogers Date: Fri, 19 May 2023 08:05:13 -0500 Subject: [PATCH] * Avoid line continuation * Fix typo and rename the method to build_errors --- lib/zendesk_apps_support/validations/requirements.rb | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/zendesk_apps_support/validations/requirements.rb b/lib/zendesk_apps_support/validations/requirements.rb index 992ce397..c89ef7f9 100644 --- a/lib/zendesk_apps_support/validations/requirements.rb +++ b/lib/zendesk_apps_support/validations/requirements.rb @@ -9,14 +9,12 @@ module Requirements class << self def call(package) unless package.has_requirements? - return [ValidationError.new(:missing_requirements)] \ - if package.manifest.requirements_only? - + return [ValidationError.new(:missing_requirements)] if package.manifest.requirements_only? + return [] end - return [ValidationError.new(:requirements_not_supported)] \ - unless supports_requirements(package) + return [ValidationError.new(:requirements_not_supported)] unless supports_requirements(package) begin requirements = package.requirements_json @@ -24,7 +22,7 @@ def call(package) return [ValidationError.new(:duplicate_requirements, duplicate_keys: e.key, count: 1)] end - erros(requirements) + build_errors(requirements) rescue JSON::ParserError => e return [ValidationError.new(:requirements_not_json, errors: e)] end @@ -175,7 +173,7 @@ def invalid_target_types(requirements) end end - def erros(requirements) + def build_errors(requirements) [].tap do |errors| errors << invalid_requirements_types(requirements) errors << excessive_requirements(requirements)