Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility wrapper oldToNewDescriptionItem returns error when value exists #35

Open
Scott-Cam opened this issue Nov 22, 2014 · 1 comment
Labels

Comments

@Scott-Cam
Copy link
Contributor

In cw.php oldToNewDescriptionItem checks the input array for the value using findValueInArray and then checks (!$dsData) if the value was found. However findValueInArray returns null on error and any other value should be valid, but checking !$dsData will return errors for such things as empty arrays. I think this should be changed to an explicit check for null $daData===null.

@alanseiden
Copy link
Collaborator

@Scott-Cam , we apologize for taking a long time to get back to this. I'd like to discuss it with you if you are still interested. No obligation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants