Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize messages in .spk file (for better reproducability of package files). #6

Open
zenhack opened this issue Oct 9, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@zenhack
Copy link
Owner

zenhack commented Oct 9, 2018

It would be nice to convert the two messages in the output .spk into capnproto canonical form. This would reduce the number of things that might cause a package to not be reproducible, since it means that e.g. if we upgrade to a newer version of the capnproto library, changes in how it allocates values inside of a message will affect the final output. We already sort the names of files in a directory, so value-significant details of a package archive should already only depend on the actual filesystem in the docker image. Besides this, the only other variable is the details of what our xz compression library does.

The canonicalization function strips off the message header, returning just a segment, so we will have to add that back to conform to the spk format, but this is easy enough to do by hand.

@zenhack zenhack added the enhancement New feature or request label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant