-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly View Feedback #28
Comments
Thanks for the feedback! Yeah, a lot of this is stuff I'm aware of/already planning on fixing, but I wanted to get the MVP out the door. Re: (4), can you show me some examples? |
I will email you a link to a video recording. |
I have taken the liberty of editing your comment to be a checklist. |
Related to the width changing (which is fixed on master), I also noticed the height of the cells sometimes changes, when you have an event with a long title. Probably should pick a sensible size and just cut it off. |
It probably should cut off the event title at maybe two rows, as opposed to the cell height. It's plausible someone may have multiple items in a row, and it may be well warranted for the cell height to grow to accommodate that. |
Quoting Jacob Weisz (2022-09-16 06:39:25)
We are now very literal about taking all available space in 0.8:
Can you explain what I'm looking at here/what the problem is? Is this on
mobile? It scales correctly for me...
|
That was desktop Firefox, it appears to go slightly wider than the iframe for some reason. |
Interesting, Firefox doesn't do that for me... I suppose I could add a small margin. |
Pushed a small update that introduces a margin; want to give it a try? |
Looks good to me! |
Still on the TODO list is making it deal with multiple events on the
same day; my thinking was in that case to squeeze the events next to
each other side-by-side. Once that's in place and there are timestamps
on the events themselves, my feeling is this will be what you want --
the event is all day. Thoughts?
Quoting Jacob Weisz (2022-09-16 06:46:33)
… Additionally, "all day" events currently just obliterate the whole day,
it looks like. Other than that, I like that events now expand to their
end times.
[1]image
--
Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe.
You are receiving this because you commented. Message ID:
***@***.***>
Verweise
1. https://user-images.githubusercontent.com/4399499/190622077-ffd58d5b-34b3-4483-a860-7659fd562241.png
2. #28 (comment)
3. https://github.com/notifications/unsubscribe-auth/AAGXYPS57UNGUG3KDTSHTXLV6RFYTANCNFSM6AAAAAAQLUJOZU
|
Yeah that sounds fine. The only other things on here then would be trying to get the view to more easily focus on the relevant/interesting part of the day, and the handling of All Day events, which shouldn't normally block out the day, I think? |
As per previous notes, I'm aware this is at an earlier stage of development, but I wanted to share my specific/actionable thoughts, in case it provides helpful ideas on approaches for improvement:
The text was updated successfully, but these errors were encountered: