Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create some PHPStan rules dedicated to Foundry #431

Open
1 of 5 tasks
nikophil opened this issue Mar 13, 2023 · 0 comments
Open
1 of 5 tasks

Create some PHPStan rules dedicated to Foundry #431

nikophil opened this issue Mar 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nikophil
Copy link
Member

nikophil commented Mar 13, 2023 •
edited
Loading

  • ensure all mandatory fields are all added to getDefaults()
  • ensure getDefaults() types match
  • ensure every attributes passed to create(), creatOne(), etc... match entity types
  • fix V2 and phpstan #623
  • ensure tests using Foundry use Factories trait
@nikophil nikophil added the enhancement New feature or request label Mar 13, 2023
@nikophil nikophil changed the title Static analysis should fail when Factory::getDefaults() misses mandatory fields Create some PHPStan rules dedicated to PHPStan Jun 29, 2023
@nikophil nikophil changed the title Create some PHPStan rules dedicated to PHPStan Create some PHPStan rules dedicated to Foundry Jun 29, 2023
@nikophil nikophil mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikophil