Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add stamps on excluded classes #123

Open
nreliberty opened this issue Nov 25, 2024 · 2 comments
Open

Do not add stamps on excluded classes #123

nreliberty opened this issue Nov 25, 2024 · 2 comments

Comments

@nreliberty
Copy link

When working on a multi application project, some of them can not add the monitoring bundle.

I have 1 application with the bundle, the other one on witch I can not install it.

The message set from the 1st one hold the MonitoringStamp.

When processing it on the other application, Messenger crashes “Zenstruck\Messenger\Monitor\Stamp\MonitorStamp” not found during decoding.”

Could we find a solution where we can specify with Message we want to exclude ?

Thank you

@nreliberty nreliberty changed the title Do not add stamps on exluded classes Do not add stamps on excluded classes Nov 25, 2024
@kbond
Copy link
Member

kbond commented Dec 16, 2024

Hmm, I am a little concerned about adding too much logic when a message is dispatched.

What about a config option that disables auto-adding the stamp. Then, you have to manually add the MonitorStamp on messages you want to have it?

@nreliberty
Copy link
Author

Hello,

Thank you for your reply.
Adding a config option to disable 'auto-adding the stamp' and mannually add the MonitorStamp on message who can use it would be a perfect solution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants