Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 394232] Division or modulo by zero in drivers/sensor/tdk/icm42688/icm42688.h #75257

Open
zephyrbot opened this issue Jul 1, 2024 · 1 comment · Fixed by #75970 · May be fixed by #82446
Open

[Coverity CID: 394232] Division or modulo by zero in drivers/sensor/tdk/icm42688/icm42688.h #75257

zephyrbot opened this issue Jul 1, 2024 · 1 comment · Fixed by #75970 · May be fixed by #82446
Assignees
@teburd @MaureenHelm @jilaypandya
Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/dcf42917c550714d2457947538b9e29d083e872e/drivers/sensor/tdk/icm42688/icm42688.h#L526

Category: Integer handling issues
Function: icm42688_accel_ms
Component: Drivers
CID: 394232

Details:

zephyr/drivers/sensor/tdk/icm42688/icm42688.h

Line 526 in dcf4291

* 

520      }
521    
522      /* Convert to micrometers/s^2 */
523      int64_t in_ms = in * SENSOR_G;
524    
525      /* meters/s^2 whole values */
>>>     CID 394232:  Integer handling issues  (DIVIDE_BY_ZERO)
>>>     In expression "in_ms / (sensitivity * 1000000LL)", division by expression "sensitivity * 1000000LL" which may be zero has undefined behavior.
526      *out_ms = in_ms / (sensitivity * 1000000LL);
527    
528      /* micrometers/s^2 */
529      *out_ums = (in_ms - (*out_ms * sensitivity * 1000000LL)) / sensitivity;
530     }
531

For more information about the violation, check the Coverity Reference. (CWE-369)

Please fix or provide comments in coverity using the link:

https://scan9.scan.coverity.com/#/project-view/29271/12996?selectedIssue=394232

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the MAINTAINERS file.
@zephyrbot zephyrbot added area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Jul 1, 2024
@teburd teburd mentioned this issue Jul 16, 2024
Merged
@nashif nashif mentioned this issue Aug 1, 2024
Merged
@zephyrbot zephyrbot reopened this Nov 25, 2024
@zephyrbot
Copy link
Collaborator Author

This coverity CID still appears as an outstanding issue. Please make sure any fixes correctly address the problem or triage the issue correctly in coverity on https://scan.coverity.com/.

@jilaypandya jilaypandya linked a pull request Dec 2, 2024 that will close this issue
drivers: sensor: tdk: fix icm42688 division by zero #82446
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teburd teburd

@MaureenHelm MaureenHelm

@jilaypandya jilaypandya

Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
4 participants
@teburd @MaureenHelm @zephyrbot @jilaypandya