Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNR unit on LoRa Receive example #82414

Open
henriquefchaves opened this issue Dec 2, 2024 · 1 comment · May be fixed by #82451
Open

SNR unit on LoRa Receive example #82414

henriquefchaves opened this issue Dec 2, 2024 · 1 comment · May be fixed by #82451
Assignees
Labels
area: LoRa bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@henriquefchaves
Copy link

henriquefchaves commented Dec 2, 2024

Describe the bug

On the LoRa receive example the code print out the SNR parameter.
I would like to have some explanation/comment regarding the receive example.
I believe SNR parameter is always a dB value
On the example it is represented with dBm, is that parameter really SNR and was some mistake or it is different from typical SNR on communications?
Thanks Guys
Very good project

@henriquefchaves henriquefchaves added the bug The issue is a bug, or the PR is fixing a bug label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Hi @henriquefchaves! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

JordanYates added a commit to Embeint/zephyr that referenced this issue Dec 2, 2024
Signal-to-noise ratio is a unitless quantity, so its unit is dB, not
dBm (dBm is the power relative to 1 milliwatt). At the same time output
the received payload using `LOG_HEXDUMP_INF`, instead of limiting the
sample solely to string payloads.

Fixes zephyrproject-rtos#82414

Signed-off-by: Jordan Yates <[email protected]>
JordanYates added a commit to Embeint/zephyr that referenced this issue Dec 2, 2024
Signal-to-noise ratio is a unitless quantity, so its unit is dB, not
dBm (dBm is the power relative to 1 milliwatt). At the same time output
the received payload using `LOG_HEXDUMP_INF`, instead of limiting the
sample solely to string payloads.

Fixes zephyrproject-rtos#82414

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates JordanYates linked a pull request Dec 2, 2024 that will close this issue
JordanYates added a commit to Embeint/zephyr that referenced this issue Dec 3, 2024
Signal-to-noise ratio is a unitless quantity, so its unit is dB, not
dBm (dBm is the power relative to 1 milliwatt). At the same time output
the received payload using `LOG_HEXDUMP_INF`, instead of limiting the
sample solely to string payloads.

Fixes zephyrproject-rtos#82414

Signed-off-by: Jordan Yates <[email protected]>
JordanYates added a commit to Embeint/zephyr that referenced this issue Dec 3, 2024
Signal-to-noise ratio is a unitless quantity, so its unit is dB, not
dBm (dBm is the power relative to 1 milliwatt). At the same time output
the received payload using `LOG_HEXDUMP_INF`, instead of limiting the
sample solely to string payloads.

Fixes zephyrproject-rtos#82414

Signed-off-by: Jordan Yates <[email protected]>
@kartben kartben added the priority: low Low impact/importance bug label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LoRa bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants