Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add board overlay for esp32c3_supermini (Closes zephyrproject-rtos/zephy/#83487) #83488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: add board overlay for esp32c3_supermini (Closes zephyrproject-rtos/zephy/#83487) #83488

wants to merge 1 commit into from
+44 −0

Conversation

elasticdotventures
Copy link

@elasticdotventures elasticdotventures commented Jan 1, 2025 •
edited by nordicjm
Loading

Fixes #83487

@zephyrbot zephyrbot added the area: Samples Samples label Jan 1, 2025
@zephyrbot zephyrbot requested review from kartben and nashif January 1, 2025 23:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

Hello @elasticdotventures, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

rruuaanng
rruuaanng reviewed Jan 2, 2025
View reviewed changes
samples/basic/blinky_pwm/boards/esp32c3_supermini.overlay
};

&pinctrl {
ledc0_default: ledc0_default {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ledc0_default: ledc0_default {
ledc0_default: ledc0-default {

samples/basic/blinky_pwm/boards/esp32c3_supermini.overlay

pwmleds {
compatible = "pwm-leds";
pwm_led_blue: pwm_led_gpio0_2 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pwm_led_blue: pwm_led_gpio0_2 {
pwm_led_blue: pwm-led-gpio0-2 {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a suggestion, If you want, you don't have to follow it.

@rruuaanng
Copy link
Collaborator

@elasticdotventures And, you should to change commit info. the format of the commit information is usually as follows:

subsys_name: ... : title

commit body info

Signed-off-by: firstname lastname <email>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rruuaanng rruuaanng rruuaanng left review comments

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

At least 2 approving reviews are required to merge this pull request.

Assignees

@kartben kartben

Labels
area: Samples Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boards/esp32c3_supermini.overlay is missing in samples/basic/blinky_pwm
4 participants
@elasticdotventures @rruuaanng @kartben @zephyrbot