drivers: flash: flash_mcux_flexspi_nor: check all 3 bytes of JEDEC ID #82448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldegrasse
requested review from
mmahadevan108 and
dleach02
as code owners
|
Marking as DNM until I have verified this change on the full set of flash chips that these switch cases should support. |
zephyrbot
requested review from
dbaluta,
de-nordic,
decsny,
manuargue,
MarkWangChinese and
rghaddab
danieldegrasse
added
the
block: HW Test
The FlexSPI NOR driver should verify all 3 bytes of the JEDEC ID match the expected value before attempting to use a custom LUT table with a flash chip. This reduces the odds that an incompatible LUT will be used with a flash chip, as some flash chips may share the same first byte of their device ID but not be compatible with the custom LUT table. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
removed
DNM
danieldegrasse
force-pushed
the
fix/flexspi-jedec-check
branch
from
27e7d99 to
58892bb
Compare
|
Hardware tests completed, PR should be good to go |
|
@jtlas19 if you'd like to try this PR on your hardware please do. I expect flash should work correctly now that we are checking all 3 bytes of the JEDEC ID. |
Awesome work, I will give this a go today. |
danieldegrasse
added
backport v3.7-branch
|
Tested and it is working on my hardware with the W25Q128JV. |
decsny
approved these changes
Dec 6, 2024
mmahadevan108
approved these changes
Dec 6, 2024
|
@de-nordic , I have added myself as the assignee as well as this touching only NXP Flash driver. |
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FlexSPI NOR driver should verify all 3 bytes of the JEDEC ID match the expected value before attempting to use a custom LUT table with a flash chip. This reduces the odds that an incompatible LUT will be used with a flash chip, as some flash chips may share the same first byte of their device ID but not be compatible with the custom LUT table.
This PR has been validated on the following flash chips using
tests/drivers/flash/common: