tests: bluetooth: tester: Add ASE ID when configuring codec #99200
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexsven
commented
Nov 11, 2025
alexsven
commented
- We want to add the ASE ID to a stream as early as possible to make sure the events coming from BTTester to Auto-PTS contains the correct information.
- Previously the events that came before stream_configured would contain ASE ID 0, regardless of actual value.
zephyrbot
added
area: Bluetooth
area: Bluetooth Audio
area: Tests
zephyrbot
added
the
area: Bluetooth Qualification
zephyrbot
requested review from
Thalley,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
nashif,
niym-ot and
sjanc
alexsven
added a commit
to alexsven/auto-pts
that referenced
this pull request
Nov 11, 2025
- Fixes: - BAP/UCL/STR/BV-532-C - BAP/UCL/STR/BV-534-C - Depends on zephyrproject-rtos/zephyr#99200
Thalley
previously approved these changes
Nov 11, 2025
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
One minor comment with an extra newline, but nothing blocking from my side
Comment on lines
+1277
to
+1279
| } else { | ||
| stream->in_use = false; | ||
| } |
Contributor
There was a problem hiding this comment.
Just a comment here for others: Streams are allocated in this clause, but in case of error of bt_bap_stream_config we should deallocate them, which is what is being added here.
It could be added a separate commit (and arguably a new function to deallocate could/should have been added), but it's a minor and simple fix that I don't think warrants that much effort.
- We want to add the ASE ID to a stream as early as possible to make sure the events coming from BTTester to Auto-PTS contains the correct information. - Previously the events that came before stream_configured would contain ASE ID 0, regardless of actual value. Signed-off-by: Alexander Svensen <[email protected]>
alexsven
force-pushed
the
add_ASE_ID_in_codec_config
branch
from
da538b6 to
311a387
Compare
|
Thalley
approved these changes
Nov 12, 2025
jhedberg
approved these changes
Nov 13, 2025
sjanc
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.