include: sys: atomic: Check for ATOMIC_OPERATIONS_BUILTIN #99202
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
previously approved these changes
Nov 11, 2025
tejlmand
previously approved these changes
Nov 11, 2025
Member
Author
|
@sylvioalves something is weird here: #99202. It seems that a lot of Espressif boards do not enable any EDIT: I think the right course of action here is to change the |
The ATOMIC_OPERATIONS_* Kconfig option is not a choice, so it does not have a default. However, the file that determines which actual atomic operations backend will be used does default to ATOMIC_OPERATIONS_BUILTIN: https://github.com/zephyrproject-rtos/zephyr/blob/3e537db71ea277ccf98adcc9e05707701e53d084/include/zephyr/sys/atomic.h#L26-L41 Since we want to ensure that all SoCs intentionally select the atomic operations backend they want to use, select it at the SoC level for all SoCs. Signed-off-by: Carles Cufi <[email protected]>
The code today relied on ATOMIC_OPERATIONS_BUILTIN being the default option if the other alternatives (_C and _ARCH) were not enabled. Instead, explicitly check for it to avoid confusion when browsing the code and to ensure that the user can always match a particular Kconfig option with the #ifdeffery in the header file. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
dismissed stale reviews from tejlmand and bjarki-andreasen
via
dd42c8a
carlescufi
force-pushed
the
atomic-kconfig-assert
branch
from
9d8ff3c to
dd42c8a
Compare
zephyrbot
added
area: Xtensa
zephyrbot
requested review from
LucasTambor,
ceolin,
marekmatej,
raffarost,
sylvioalves,
uLipe and
wmrsouza
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code today relied on ATOMIC_OPERATIONS_BUILTIN being the default option if the other alternatives (_C and _ARCH) were not enabled. Instead, explicitly check for it to avoid confusion when browsing the code and to ensure that the user can always match a particular Kconfig option with the #ifdeffery in the header file.