Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove websocket_ticks binary #32

Open
rhnvrm opened this issue Jul 4, 2021 · 2 comments
Open

Remove websocket_ticks binary #32

rhnvrm opened this issue Jul 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rhnvrm
Copy link
Member

rhnvrm commented Jul 4, 2021 •
edited
Loading

We should not check-in this binary and figure out a better way to mock websocket.

Ref: #30
@rhnvrm rhnvrm mentioned this issue Jul 4, 2021
Merged
@bhumitattarde
Copy link
Collaborator

  1. What are the disadvantages of current approach?
  2. How would you like to go about this?

@rhnvrm
Copy link
Member Author

rhnvrm commented Jul 5, 2021

I explored this further today and ported one of our internal tests to gokiteconnect.

zerodha/gokiteconnect#55

This is based on packets added to mock_responses which I added that use the latest snapshots:

zerodha/kiteconnect-mocks@fd12de1

It uses base64 encoded packets of "full" and "quote" mode packets.

I think we can do something similar in cppkiteconnect and other libs as well.

@bhumitattarde bhumitattarde added the enhancement New feature or request label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhnvrm @bhumitattarde