Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread name argument to KiteTicker.connect() #191

Open
skazazes-work opened this issue Feb 8, 2024 · 1 comment · May be fixed by #192
Open

Add thread name argument to KiteTicker.connect() #191

skazazes-work opened this issue Feb 8, 2024 · 1 comment · May be fixed by #192

Comments

@skazazes-work
Copy link

Hello,

I would like to be able to pass a thread name to the KiteTicker.connect() function in order to disambiguate output to the logging module when including thread names in log formatters. I am happy to make the changes myself, but would like to know if they could be merge in if I do.

Thanks!

@skazazes-work
Copy link
Author

Another option, and arguably the better solution, would be to enable setting opts["installSignalHandlers"]=False when the function is called without threaded=True.

As of right now, you cannot call KiteTicker.connect() inside of a thread you have already spawned as a result of the signal handlers.
Instead you have to call it with the threaded=True argument, causing two threads to be spawned when only on is really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant