Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all Receive occurence into Outbound #1797

Closed
lumtis opened this issue Feb 23, 2024 · 0 comments · Fixed by #2118
Closed

Rename all Receive occurence into Outbound #1797

lumtis opened this issue Feb 23, 2024 · 0 comments · Fixed by #2118
Assignees
@lumtis
Labels
code-quality Code quality improvement

Comments

@lumtis
Copy link
Member

lumtis commented Feb 23, 2024

Same as for #1082.
We used to have the naming:

  • send for inbound
  • receive for outbound

There are still some places in the code where we use the receive naming:

node/zetaclient/zetabridge/tx.go

Line 373 in f15eb49

b.logger.Debug().Err(err).Msgf("PostVoteOutbound broadcast fail | Retry count : %d", i+1)

Need to change those as it might seem very confusing for anyone reading the code
@lumtis lumtis added the code-quality Code quality improvement label Feb 23, 2024
@lumtis lumtis self-assigned this May 5, 2024
@lumtis lumtis mentioned this issue May 6, 2024
Merged
@lumtis lumtis linked a pull request May 6, 2024 that will close this issue
refactor: consolidate inbound and outbound naming #2118
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
code-quality Code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: consolidate inbound and outbound naming zeta-chain/node
1 participant
@lumtis