Files that changed from the base of the PR and between 93ebef4 and 643490d.

• .github/workflows/simulation-test.yaml (1 hunks)
• Makefile (2 hunks)
• app/app.go (1 hunks)
• app/export.go (2 hunks)
• changelog.md (1 hunks)
• docs/development/SIMULATION_TESTING.md (1 hunks)
• tests/simulation/sim/sim_utils.go (2 hunks)
• tests/simulation/sim_test.go (7 hunks)

tests/simulation/sim/sim_utils.go (1)

76-99: Add unit tests for the new function.

The static analysis indicates that the new function lacks test coverage. This is critical for simulation-related code.

Would you like me to help create unit tests for this function? The tests should cover:

1. Successful export of both state and params
2. Error cases for ExportAppStateAndValidators
3. Error cases for file operations
4. Cases where export paths are not defined

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 76-81: tests/simulation/sim/sim_utils.go#L76-L81
Added lines #L76 - L81 were not covered by tests

---

[warning] 83-85: tests/simulation/sim/sim_utils.go#L83-L85
Added lines #L83 - L85 were not covered by tests

---

[warning] 88-92: tests/simulation/sim/sim_utils.go#L88-L92
Added lines #L88 - L92 were not covered by tests

---

[warning] 94-96: tests/simulation/sim/sim_utils.go#L94-L96
Added lines #L94 - L96 were not covered by tests

---

[warning] 98-98: tests/simulation/sim/sim_utils.go#L98
Added line #L98 was not covered by tests

.github/workflows/simulation-test.yaml (3)

1-20: Consider using a more concise workflow name.

As suggested in the previous review, using shorter names like name: sim would improve readability in PR checks while maintaining clarity.

---

22-27: Well-implemented concurrency control.

The concurrency configuration effectively prevents parallel runs and manages resources efficiently.

---

65-76: ⚠️ Potential issue

Security: Fix command injection vulnerability in manual run.

The current implementation is vulnerable to command injection. While the environment variable is properly quoted, this job could be merged with the main simulation job.

Merge this with the main job by adding a conditional step:

- name: Manual Test Run
  if: github.event_name == 'workflow_dispatch'
  env:
    TEST_TARGET: ${{ github.event.inputs.test-target }}
  run: make "$TEST_TARGET"

app/export.go (1)

162-162: Document key structure and verify address extraction.

The validator address extraction uses a magic number (2) for the key offset. This assumes a specific key structure that should be documented.

Let's verify the key structure:

Consider adding a comment explaining the key structure:

+		// Validator address starts at index 2 in the key following the prefix bytes
 		addr := sdk.ValAddress(iter.Key()[2:])

Makefile (4)

384-384: LGTM: Echo command formatting improvement

The removal of trailing ellipsis enhances clarity while maintaining functionality.

---

395-399: LGTM: Well-structured new simulation tests

The new import/export simulation tests are properly configured with parameters matching existing tests, ensuring consistent test execution patterns.

---

421-425: LGTM: Proper .PHONY declarations

All new simulation test targets are correctly declared as .PHONY targets, ensuring proper Make behavior.

---

390-390: Verify the reduced timeout values

The timeout reduction from 2h to 30m is significant. While this improves CI pipeline efficiency, please ensure that these tests consistently complete within the new 30m limit across different environments and conditions.

Also applies to: 393-393

app/app.go (1)

1063-1065: LGTM: Clean implementation of ModuleManager getter.

The method provides a clean way to access the module manager, which aligns well with the PR's testing objectives.

changelog.md (1)

Line range hint 1-1000: LGTM! Well-structured changelog.

The changelog follows best practices with clear version headers, categorized changes, and proper PR references. Breaking changes are appropriately highlighted at the start of each version.

Files that changed from the base of the PR and between 93ebef4 and 643490d.

• .github/workflows/simulation-test.yaml (1 hunks)
• Makefile (2 hunks)
• app/app.go (1 hunks)
• app/export.go (2 hunks)
• changelog.md (1 hunks)
• docs/development/SIMULATION_TESTING.md (1 hunks)
• tests/simulation/sim/sim_utils.go (2 hunks)
• tests/simulation/sim_test.go (7 hunks)

tests/simulation/sim/sim_utils.go (1)

4-13: LGTM: Import organization follows best practices

The new imports are properly organized and all are utilized in the new functionality.

.github/workflows/simulation-test.yaml (4)

1-21: LGTM: Well-structured workflow triggers.

The workflow configuration provides comprehensive coverage with automated triggers (push, PR, scheduled) and manual execution capability.

---

22-27: LGTM: Effective concurrency control.

The concurrency configuration efficiently manages resources by preventing parallel runs and canceling outdated executions.

---

30-44: LGTM: Clean dependency installation setup.

The job properly sets up the environment with specific versions and required dependencies.

---

65-76: LGTM: Secure manual test execution.

The manual-run job properly handles user input through environment variables, preventing shell injection vulnerabilities.

app/export.go (1)

78-78: LGTM: Error handling aligns with expected behavior.

The explicit error ignoring is appropriate here as some validators might not have any commission to withdraw.

Makefile (3)

384-384: LGTM: Echo command formatting improvement.

The removal of trailing ellipsis enhances command output clarity.

---

421-425: LGTM: Proper .PHONY declarations for new targets.

All new test targets are correctly declared as .PHONY targets, following Makefile best practices.

---

390-393: Verify if 30m timeout is sufficient for simulation tests.

The timeout reduction from 2h to 30m is significant. While this change improves CI pipeline efficiency, we should verify that 30m is sufficient based on historical test execution times.

✅ Verification successful

After analyzing the simulation tests implementation and context, I can now provide a final response:

30-minute timeout appears sufficient for simulation tests

The simulation tests are well-structured with reasonable parameters:

• Tests run with 100 blocks and 200 transactions per block
• Multiple test variations run with controlled complexity:
  • TestAppStateDeterminism: 3 seeds × 5 runs each
  • TestFullAppSimulation: Single comprehensive run
  • Import/Export tests: Single iteration with verification

The 30-minute timeout should be adequate because:

1. The tests use moderate simulation parameters (100 blocks, 200 tx/block)
2. The implementation includes proper cleanup and resource management
3. No timeout-related failures were found in the git history
4. The test structure allows for parallel execution where applicable

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check historical test execution times in GitHub Actions

# Search for previous test runs and their durations
gh run list --workflow simulation-test.yaml --json conclusion,durationMs,name --jq '.[] | select(.name | contains("test-sim-nondeterminism") or contains("test-sim-fullappsimulation")) | {name: .name, duration_minutes: (.durationMs/60000), conclusion: .conclusion}'

Length of output: 502

---

Script:

#!/bin/bash
# Let's try a different approach to check workflow runs using available fields
gh run list --workflow simulation-test.yaml --json conclusion,startedAt,updatedAt,name --jq '.[] | select(.name | contains("test-sim-nondeterminism") or contains("test-sim-fullappsimulation")) | {name: .name, duration_minutes: (((.updatedAt | fromdateiso8601) - (.startedAt | fromdateiso8601))/60), conclusion: .conclusion}' | head -n 10

Length of output: 339

---

Script:

#!/bin/bash
# Also check if there's a dedicated workflow file for these tests
fd -e yml -e yaml simulation

Length of output: 30

---

Script:

#!/bin/bash
# Check if there are any comments or documentation about these timeouts
rg -i "timeout.*simulation|simulation.*timeout" -A 2 -B 2

Length of output: 267

---

Script:

#!/bin/bash
# Let's examine the run-sim-test function definition and its usage context
rg "run-sim-test" -A 5 -B 5 Makefile

Length of output: 1036

---

Script:

#!/bin/bash
# Check for any historical comments or discussions about simulation timeouts
git log -p | rg -i "simulation.*test.*timeout|timeout.*simulation" -A 3 -B 3

Length of output: 1128

---

Script:

#!/bin/bash
# Look for simulation test implementations to understand their complexity
fd -e go . -x rg -l "TestAppStateDeterminism|TestFullAppSimulation" {}

Length of output: 105

---

Script:

#!/bin/bash
# Let's examine the simulation test implementations
cat tests/simulation/sim_test.go

Length of output: 14779

---

Script:

#!/bin/bash
# Check if there are any recent CI failures related to timeouts
git log -p | rg -i "fail.*timeout.*simulation|simulation.*timeout.*fail" -A 3 -B 3

Length of output: 84

---

Script:

#!/bin/bash
# Look for any configuration files that might contain historical timeout values
fd -e toml -e yaml -e json . -x rg -l "timeout"

Length of output: 207

app/app.go (1)

1063-1065: LGTM: Clean getter implementation.

The ModuleManager() method provides a clean way to access the module manager, which is necessary for the new simulation tests. The implementation follows the standard Go getter pattern.

changelog.md (1)

Line range hint 1-1000: LGTM! Well-structured changelog.

The changelog follows best practices with:

• Clear version sections
• Categorized changes
• PR links for traceability
• Breaking changes clearly highlighted