From f9ef655a0339ea9aba0afe887f11de5e10f38a29 Mon Sep 17 00:00:00 2001 From: skosito Date: Mon, 5 Aug 2024 21:37:01 +0200 Subject: [PATCH] add issue to todos --- v2/scripts/deploy/deterministic/DeployGatewayEVM.s.sol | 6 +++--- v2/scripts/deploy/deterministic/UpgradeGatewayEVM.s.sol | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/v2/scripts/deploy/deterministic/DeployGatewayEVM.s.sol b/v2/scripts/deploy/deterministic/DeployGatewayEVM.s.sol index 220d13324..224bff437 100644 --- a/v2/scripts/deploy/deterministic/DeployGatewayEVM.s.sol +++ b/v2/scripts/deploy/deterministic/DeployGatewayEVM.s.sol @@ -8,12 +8,12 @@ import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy contract DeployGatewayEVMCreate2 is Script { function run() external { - // TODO: should be passed as arg + // TODO (https://github.com/zeta-chain/protocol-contracts/issues/251): should be passed as arg string memory mnemonic = "test test test test test test test test test test test junk"; uint256 privateKey = vm.deriveKey(mnemonic, 0); address deployer = vm.rememberKey(privateKey); - // TODO: should be passed as arg + // TODO (https://github.com/zeta-chain/protocol-contracts/issues/251): should be passed as arg address payable tss = payable(vm.envOr("TSS_ADDRESS", address(0x123))); address admin = vm.envOr("ADMIN_ADDRESS", deployer); @@ -25,7 +25,7 @@ contract DeployGatewayEVMCreate2 is Script { vm.startBroadcast(deployer); - // TODO: should be passed as arg + // TODO (https://github.com/zeta-chain/protocol-contracts/issues/251): should be passed as arg TestERC20 zeta = new TestERC20("zeta", "ZETA"); expectedImplAddress = computeCreate2Address( diff --git a/v2/scripts/deploy/deterministic/UpgradeGatewayEVM.s.sol b/v2/scripts/deploy/deterministic/UpgradeGatewayEVM.s.sol index a34e78ebc..dfe6f3831 100644 --- a/v2/scripts/deploy/deterministic/UpgradeGatewayEVM.s.sol +++ b/v2/scripts/deploy/deterministic/UpgradeGatewayEVM.s.sol @@ -10,12 +10,12 @@ import { Upgrades } from "openzeppelin-foundry-upgrades/Upgrades.sol"; contract UpgradeGatewayEVM is Script { function run() external { - // TODO: should be passed as arg + // TODO (https://github.com/zeta-chain/protocol-contracts/issues/251): should be passed as arg string memory mnemonic = "test test test test test test test test test test test junk"; uint256 privateKey = vm.deriveKey(mnemonic, 0); address deployer = vm.rememberKey(privateKey); - // TODO: should be passed as arg + // TODO (https://github.com/zeta-chain/protocol-contracts/issues/251): should be passed as arg address proxy = vm.envOr("PROXY_ADDRESS", address(0xA7806c719bd377F15bA6CaDf2F94Afb7FfA66256)); GatewayEVM prevImpl = GatewayEVM(proxy);