Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v1 zevm from code coverage #238

Closed
lumtis opened this issue Jul 18, 2024 · 0 comments · Fixed by #268
Closed

Remove v1 zevm from code coverage #238

lumtis opened this issue Jul 18, 2024 · 0 comments · Fixed by #268
Assignees
@skosito

Comments

@lumtis
Copy link
Member

lumtis commented Jul 18, 2024

Old zevm still appear in codecoverage: https://app.codecov.io/github/zeta-chain/protocol-contracts/tree/main/contracts

While we're supposed to only take Foundry test in consideration.

We should only use prototypes in scope for the code coverage
@skosito skosito self-assigned this Jul 23, 2024
@skosito skosito mentioned this issue Jul 30, 2024
Merged
@skosito skosito linked a pull request Jul 30, 2024 that will close this issue
refactor: v1 v2 split #268
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skosito skosito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: v1 v2 split zeta-chain/protocol-contracts
2 participants
@lumtis @skosito