-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grub "root=ZFS=..." misses zpool #22
Comments
I tracked a bit further down:
But
Same happens with Note: My zfs root is placed on sda4 and sdb4 in raidz1. |
I got the exact same issue on Debian Sid, grub-common 2.02-beta2.9-ZOL11-7aa9f6. Using
However, when using
I pasted -vvv output into https://gist.github.com/dechamps/8ebdf9c3631bd0cda2ef. |
For now, this can be worked around without touching package files by manually specifying |
is this repo still active? i'm seeing exactly the same issue, 18 months later... |
apparently the bug is due to the fact that grub-mkconfig is doing a 'head -n1' on your grub-probe output. and later on when grub-probe is called again it needs to be passed a quorum of devices in order to determine the filesystem type and label. |
grub-probe can't determine filesystem type when you are trying to get it from one of raidz disks. |
This can be worked around by editing
By :
You can also just hardcode your root pool name:
|
Hello everyone, I believe I've just crashed into exactly this issue, an extremely similar issue, or the same outcome caused by different circumstances. In my case,
Adding
versus
Note how I make the (IMO reasonably solid) argument over at https://savannah.gnu.org/bugs/index.php?58555 that this is because If I remember :) I'll update this thread. |
This workaround fixes it but it's still an issue as of 2.05_alpha20200310. |
This is an issue on my machine with grub-2.05_alpha20200310 |
What's the long wait on this issue for? It's been open for 6 years. There's even a fix in the comments. |
Apparently a patch was submitted to grub itself back in december, which was reviewed but then got dropped due to some other side-effect (see replies in that thread). I wonder if it just needs the final nudge. |
It's because that patch throws a grub_probe error. Here's the output I get upon using GRUB patched with it:
And here's with @pstch 's patch:
|
@vhns Your two pastes are identical. |
I got bitten by this recently, pool name not being included in the line of linux kernel options :< |
Hi, this issue seem still exist in grub 2.06-r2. I recently try to install gentoo on zfs, after all installation process and out of chroot everything work, but when I rebuild the system with I will try the work around in this issue and update the result. |
@tomtastic is there any news on this patch landing so this annoying bug can be fixed soon ? |
No sadly Daniel Kiper ignored my message to the mailing list and also those I sent him individually. |
It is kinda said that the bug is not being fixed. I don't have bpool and rpool split and grub happily leaves in uefi vfat32 partition, while root is an unsupported by grub ZFS filesystem (with feature flags like compression, etc). The grub-probe doesn't recognize it as ZFS. I replaced rpool= in 10_linux with:
|
Maybe, it's time to replace grub with something else. |
Grub gets the work done and has low complexity and sufficient flexibility for my needs. |
Grub itself doesn't have low complexity, but the fact that people stopped caring about fixing grub bugs is enough for me to look for alternatives. Someone already proposed a bug fix which has been ignored for years. This is a serious issue in itself. |
@IvanVolosyuk Grub will probably never support number of features zfs has. I myself use zfsbootmenu and booting it within grub so i can have os-prober with other operating systems while having option to tinker with my zfs ones. |
Perhaps, I can combine zfsbootmenu with limine. |
I tried zfsbootmenu and I stayed with grub as it work better for my setup. I don't have a requirement for grub to understand ZFS structure as I install it on fat32 partition and initramfs has full understanding of ZFS. The only quirk is the config updater scripts which I have to patch. |
That's already bad enough. The problem is that patches are not merged into the core. We are forced to carry hacks. |
Ok, changed to systemd-boot with my custom install scripts for compatibility with genkernel. |
thank you for this. I've got workaround as "zpool create -o compatibility=grub2 ....". After that "grub2-probe.." worked well. |
Hello,
I use Debian "Jessie" with zfs 0.6.4-1.1-2 and root on zfs. The root pool is "tank0".
After upgrading to grub 2.02-beta2.9-ZOL1, the grub.cfg misses the pool part, i.e. it becomes e.g.
This does not work, it should be e.g.
Also, at running "update-grub", I got
The root filesystem is placed on GPT parted disks (raidz1) partitition 4. The other partititions are used for gtp grub and md1 (carrying an ext4 based rescue system and swap, this is why the update-grub creates so many entries). In more detail:
3.19.8 and 3.19.3 are one zfs (active root) only.
3.16.0-4-amd64 andn memtest are one zfs and ext4 (rescue).
And there is a complete backup of zfs placed on
/dev/sdi1
. This looks to break GRUB as well, because it creates only entries for 3.16.0-4-amd64, these multiple times, with increasing numbers ofauf /dev/sdi1
, looking like:grub-probe works:
GRUB installation is:
The text was updated successfully, but these errors were encountered: