From ac3277cae8b293e6872076bf0e7c5a72ed7b1bc5 Mon Sep 17 00:00:00 2001 From: senmiaoliu Date: Tue, 19 Mar 2024 10:39:35 +0800 Subject: [PATCH] [KYUUBI #6182] JDBC engine using the overlay conf as session conf MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # :mag: Description ## Issue References ๐Ÿ”— ## Describe Your Solution ๐Ÿ”ง Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf. ## Types of changes :bookmark: - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan ๐Ÿงช #### Behavior Without This Pull Request :coffin: #### Behavior With This Pull Request :tada: #### Related Unit Tests --- # Checklist ๐Ÿ“ - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf. Closes #6182 9ca8b487a [senmiaoliu] Using the overlay conf as session conf Authored-by: senmiaoliu Signed-off-by: Cheng Pan --- .../org/apache/kyuubi/engine/jdbc/session/JdbcSessionImpl.scala | 1 + 1 file changed, 1 insertion(+) diff --git a/externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/session/JdbcSessionImpl.scala b/externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/session/JdbcSessionImpl.scala index 09d08d2c896..9e2ffe858c7 100644 --- a/externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/session/JdbcSessionImpl.scala +++ b/externals/kyuubi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/session/JdbcSessionImpl.scala @@ -53,6 +53,7 @@ class JdbcSessionImpl( kyuubiConf.set(ENGINE_JDBC_CONNECTION_USER, user) kyuubiConf.set(ENGINE_JDBC_CONNECTION_PASSWORD, password) } + conf.foreach { case (k, v) => kyuubiConf.set(k, v) } kyuubiConf }