chore: more covarges

zhaozg · Mar 30, 2024 · 19653be · 19653be
1 parent 8adbe13
commit 19653be
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 24 deletions.
diff --git a/src/pkcs7.c b/src/pkcs7.c
@@ -136,13 +136,7 @@ static LUA_FUNCTION(openssl_pkcs7_set_content)
   PKCS7 *p7 = CHECK_OBJECT(1, PKCS7, "openssl.pkcs7");
   PKCS7 *content = CHECK_OBJECT(2, PKCS7, "openssl.pkcs7");
 
-  int ret = PKCS7_set_content(p7, content);
-  if (ret == 1)
-  {
-    lua_pushvalue(L, 1);
-    lua_pushvalue(L, 2);
-    lua_rawset(L, LUA_REGISTRYINDEX);
-  }
+  int ret = PKCS7_set_content(p7, PKCS7_dup(content));
   return openssl_pushresult(L, ret);
 }
 

diff --git a/test/6.pkcs7.lua b/test/6.pkcs7.lua
@@ -63,27 +63,33 @@ function TestPKCS7:testNew()
   der = assert(p7:export())
   assert(openssl.pkcs7.read(der, 'auto'))
 
-  if helper.openssl3 then
-  --p7 = openssl.pkcs7.create({
-  --    ca.cacert,
-  --    cert
-  --  }, {ca.crl})
-  --assert(p7:parse())
-  --assert(p7:export())
-
-  --assert(p7:export('der'))
-  else
-  p7 = openssl.pkcs7.new()
-  p7:add(ca.cacert)
-  p7:add(cert)
-  p7:add(ca.crl)
+  local p = openssl.pkcs7.new()
+  p:add(ca.cacert)
+  p:add(cert)
+  p:add(ca.crl)
+  assert(p:parse())
+  assert(p:export())
+
+  -- FIXME: illegal zero content
+  assert(p:export('der'))
+  local ln, sn = p:type()
+  assert(ln)
+  assert(sn)
+
+  p7 = openssl.pkcs7.create({
+      ca.cacert,
+      cert
+    }, {ca.crl})
   assert(p7:parse())
   assert(p7:export())
 
-  assert(p7:export('der'))
-  end
+  -- TODO: enable below
+  -- p7:set_content(p)
 
-  local ln, sn = p7:type()
+  -- FIXME: illegal zero content
+  -- assert(p7:export('der'))
+  ln, sn = p7:type()
   assert(ln)
   assert(sn)
+
 end