Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong testing setting #1

Open
Sam1224 opened this issue Feb 14, 2023 · 1 comment
Open

Wrong testing setting #1

Sam1224 opened this issue Feb 14, 2023 · 1 comment

Comments

@Sam1224
Copy link

Sam1224 commented Feb 14, 2023

Hi, it seems that your testing setting is wrong. In utils.py (METR-LA), Line 86-92, both of inputs and ground truth only contain values of unknown roads, so the task is data reconstruction. However, in data kriging, we should use known roads to infer (and evaluate) unknown roads during testing.
@Sam1224
Copy link
Author

Sam1224 commented Feb 14, 2023

Hi, it seems that your testing setting is wrong. In utils.py (METR-LA), Line 86-92, both of inputs and ground truth only contain values of unknown roads, so the task is data reconstruction. However, in data kriging, we should use known roads to infer (and evaluate) unknown roads during testing.

It's interesting that your model could still work when I change the test setting to that of IGNNK :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sam1224