Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to add Japanese. #1448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

I want to add Japanese. #1448

wants to merge 2 commits into from

Conversation

Takesikaityo
Copy link

I'm Japanese.
So I want to add Japanse.

たけしかいちょー(takesi) added 2 commits February 13, 2017 19:52
I'm Japanese.
So I want to add Japanse.
@TheDiamondYT1
Copy link

Lol

@lemoncmd
Copy link

lemoncmd commented Jul 22, 2017

I think that this looks generally nice, but I have an opinion about some bad points.
I'll write down the list of the points in Japanese.

非常に長い振動→振動を長くする
レルム→Realms(英名で定着しているため)
略)4つ以上のパッチを修正する→略)4つ以上のパッチを適用する
略)パッチ適用できません。→略)パッチを適用できません。
著作権表示は訳すべきではない(about_copyright)
BlockLauncherテストのレポ→BlockLauncherテスト用のリポジトリ

"。"を付けるか付けないか、或いは体言止めにするか否か等の書式はなるべく整えるべき

@Takesikaityo
Copy link
Author

ありがとうございます

@lemoncmd
Copy link

これはあくまで個人としての意見ですが、ご参考になれば幸いです。

@TheDiamondYT1
Copy link

You realise BlockLauncher isnt open source anymore... Lol

@lemoncmd
Copy link

@TheDiamondYT1 Maybe he pull-requested to offer his opinion, not to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants