-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Colab giving version control error. #104
Comments
cc: @matthewcarbone |
@ziatdinovmax I think I can solve this with another try/except. Can you post the full error? I think I know what the issue is. That said I think we should urge people not to install via |
I think problem is in (https://github.com/ziatdinovmax/gpax/blob/main/gpax/_version.py) Except block with RuntimeError should fix this /usr/local/lib/python3.10/dist-packages/gpax/init.py in /usr/local/lib/python3.10/dist-packages/gpax/_version.py in |
@utkarshp1161 apologies I didn't even realize in my initial response it wasn't Maxim who raised this issue or I would've responded to you! Anyway this should be fixed in #105. |
No problem. Thanks a lot. Our group uses gpax all the time in colab and they happen to build it from main branch in most of their notebooks. |
@utkarshp1161 Sounds good! Just a quick bit of feedback: I would strongly recommend against pip installing from main. Unless you know exactly what's on the main branch you should use The great irony is that the PR's that introduced this new bug were meant to make this deployment procedure more robust 😁 |
I see. Makes complete sense. I will pass it on to the group members. |
@utkarshp1161 should also wait for @ziatdinovmax's opinion, as it's his code, but in terms of best development practices you can't go wrong with installing from PyPI 👍 I've opened a PR with updated installation instructions and we'll wait for Maxim to comment! |
@utkarshp1161 thanks for identifying this issue and thanks @matthewcarbone for promptly fixing it! |
Gives above error if using:
pip install git+https://github.com/ziatdinovmax/gpax
below works:
pip install gpax
The text was updated successfully, but these errors were encountered: