don't open every zig file in the workspace just to look for tests #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Not sure how I missed that but this has been making ZLS unusable for me in the Zig repo. I guess it's a combination of my system being a bit unstable lately and not spending as much time in that repo. Do you think you might have any more small fixes coming or should I release a 0.6.2 right away? |
|
I don't have any more fixes planned for now. Feel free to tag a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I noticed that ZLS started to open files even though I didn't open them myself. I didn't think much of it until I checked out the Zig compiler codebase today and saw ZLS endlessly loading files. The project currently contains 2929 .zig files. The cause has been the ZigTestRunnerProvider which is trying to open every zig file to search for tests.
Identifying the tests of a workspace is not easily done correctly but this is just asking the extension to self destruct.