Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some GPA tests are disabled on WASI #22731

Open
mlugg opened this issue Feb 3, 2025 · 0 comments
Open

Some GPA tests are disabled on WASI #22731

mlugg opened this issue Feb 3, 2025 · 0 comments
Assignees
@andrewrk
Labels
arch-wasm 32-bit and 64-bit WebAssembly bug Observed behavior contradicts documented or intended behavior os-wasi standard library This issue involves writing Zig code for the standard library.
Milestone
0.14.0

Comments

@mlugg
Copy link
Member

mlugg commented Feb 3, 2025

In #20271 (which I expect to be merged imminently), I have had to disable some std.heap.GeneralPurposeAllocator tests on wasm32-wasi (no libc) because they started failing for no clear reason. These tests run without crashing, but end up reporting leaks.

  • The failure consistently reproduces locally when running the whole standard library tests.
  • It does not reproduce if the failing tests are extracted to their own file.
  • It does not reproduce when filtering for only the GPA tests or only a failing test.

Since the repro seems to care about the rest of the test binary, it seems like #20271 has just exposed a pre-existing bug, particularly since that PR doesn't change anything which could reasonably affect GPA.
@mlugg mlugg added arch-wasm 32-bit and 64-bit WebAssembly bug Observed behavior contradicts documented or intended behavior os-wasi standard library This issue involves writing Zig code for the standard library. labels Feb 3, 2025
@mlugg mlugg added this to the 0.15.0 milestone Feb 3, 2025
mlugg added a commit to MasonRemaley/zig that referenced this issue Feb 3, 2025
@mlugg
std.heap.GeneralPurposeAllocator: disable some tests on wasm32-wasi
dc5c827 
The ZON PR (ziglang#20271) is causing these tests to inexplicably fail. It
doesn't seem like that PR is what's breaking GPA, so these tests are now
disabled. This is tracked by ziglang#22731.
@andrewrk andrewrk self-assigned this Feb 3, 2025
@andrewrk andrewrk modified the milestones: 0.15.0, 0.14.0 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewrk andrewrk

Labels
arch-wasm 32-bit and 64-bit WebAssembly bug Observed behavior contradicts documented or intended behavior os-wasi standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
2 participants
@andrewrk @mlugg