From 225fa45836776232a52a216a4610d9c78ccf65e4 Mon Sep 17 00:00:00 2001 From: TheJulianJES Date: Wed, 25 Sep 2024 00:21:10 +0200 Subject: [PATCH] Always set effect on members Changing any other attributes always turns off the effect at the moment, so we need to pass that to the members. --- zha/application/platforms/light/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zha/application/platforms/light/__init__.py b/zha/application/platforms/light/__init__.py index 04001636..92a64296 100644 --- a/zha/application/platforms/light/__init__.py +++ b/zha/application/platforms/light/__init__.py @@ -1243,8 +1243,8 @@ def _make_members_assume_group_state( update_params[ATTR_COLOR_MODE] = self._color_mode update_params[ATTR_XY_COLOR] = self._xy_color - if service_kwargs.get(ATTR_EFFECT) is not None: - update_params[ATTR_EFFECT] = self._effect + # setting any other attribute will turn the effect off, so we always set this + update_params[ATTR_EFFECT] = self._effect for platform_entity in self.group.get_platform_entities(Light.PLATFORM): platform_entity._assume_group_state(update_params)