Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IKEA Starkvind test #127

Open
TheJulianJES opened this issue Aug 4, 2024 · 0 comments
Open

Improve IKEA Starkvind test #127

TheJulianJES opened this issue Aug 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@TheJulianJES
Copy link
Contributor

Regarding the issue fixed here (infinite recursion):

It seems like we do have a unit test for this in test_fan.py, but it didn't catch the issue, as we're (1) not testing getting a fan_mode attribute report from the device and/or (2) because when fan_mode is changed from ZHA, we're only checking if the attribute was written correctly. Not if the entity was also updated correctly.
Doing either of those things would have caught the issue.

Further fixes and changes will come with #87 in the future.
We should also make sure the Starkvind test is improved for this scenario there (test speed) or shortly after that PR is merged.

@TheJulianJES TheJulianJES added the enhancement New feature or request label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant