Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable command history shortcut #8

Open
josesa opened this issue Oct 12, 2024 · 2 comments
Open

Enable command history shortcut #8

josesa opened this issue Oct 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@josesa
Copy link

josesa commented Oct 12, 2024

Is your feature request related to a problem? Please describe.

fzf supports command history search with the CTRL-R shortcut. This module doesn't enable that shortcut.

Describe the solution you'd like

Option to enable the CTRL-R shortcut in fzf module

Describe alternatives you've considered

The only option I found was to remove the module and install zfz independently.

Additional context

No response

@josesa josesa added the enhancement New feature or request label Oct 12, 2024
@cstrahan
Copy link
Contributor

cstrahan commented Oct 30, 2024

CTRL-R works fine for me, using this plugin. Are you sure you don't have some other conflicting config, @josesa?

Note that this plugin expects that you've installed the fzf executable somewhere on your $PATH, so you should some something like this if you echo ${commands[fzf]}:

% echo "${commands[fzf]}"
/Users/cstrahan/.local/bin/fzf

That's showing that zsh found fzf at $HOME/.local/bin/fzf, because that's where I installed it, and $HOME/.local/bin is on my $PATH.

@kaznovac
Copy link
Contributor

@josesa I second the @cstrahan

these lines effectively execute and cache the fzf's builtin zsh integration (this includes ctrl+r support)
https://github.com/zimfw/fzf/blob/8125990fb3d53f0716720e08ddccfb9a6abf5608/init.zsh#L1-10
please verify that you have fzf in your path (here's yet another command to check which -a fzf - this will list all fzfs available to your shell)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants