Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version checking fails if non executable bins #22

Open
nachog00 opened this issue Feb 5, 2025 · 2 comments
Open

version checking fails if non executable bins #22

nachog00 opened this issue Feb 5, 2025 · 2 comments

Comments

@nachog00
Copy link
Contributor

nachog00 commented Feb 5, 2025

If the download of binaries falls short, binaries become un-executable.
Version checking doesn't take this into account and outputs "wrong version string" when the version isn't even known.

@ala-mode
Copy link
Contributor

ala-mode commented Feb 5, 2025

Checking the version string is part of our (maybe over-elaborate) way of verifying that the downloaded files are correct and complete, so this is expected behavior.

That is to say, an incomplete file is not any version of the binary, and thus should fail this check.

@ala-mode ala-mode closed this as completed Feb 5, 2025
@nachog00
Copy link
Contributor Author

nachog00 commented Feb 5, 2025

I agree, but the error showed has to change. If the binary isn't executable, we shouldn't be saying "Error: version mismatch".

stdout gives a very explicit message in those cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants